Make the live screen say what it is about to do, and then do it - #80
Merged
Merged
Conversation
Four fixes to the touchline screen, all of them about the gap between what a plan says and what has actually happened. The minutes table is headed "Planned minutes" until the first kick-off. Its figures there are the line-up costed at a full period each, which is not time anyone has played — and the numbers themselves cannot say which they are, so the heading does. "Show subs" folded the bench strip away, which was never the strip anyone wanted rid of. It now folds the substitutions out of the timeline instead, leaving the goals; a rotated squad buries them among swaps nobody is scrolling back for. The bench is always drawn. "Next line-up" leaves the clock controls for the foot of the "Changes at half-way" card, and the dialog that used to ask first goes with it: the list it now sits under is what that dialog was there to say. That only holds if the list is true, and it was not. Play overtakes a plan: once the player a planned swap takes off has gone off live, the difference between the two line-ups still names their slot but proposes withdrawing whoever came on for them. Those swaps are dropped from the card — and from what the button does, so an injury replacement keeps the place for the rest of the half instead of lasting exactly one quarter. AdvancePeriodAsync applies PlannedChangesReport's answer rather than forming a second one, because a card promising one thing while the button under it does another is worse than either behaviour alone. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AfrvWcNR8hMjw3ny6dMemX
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four fixes to the touchline screen, all of them about the gap between what
a plan says and what has actually happened.
The minutes table is headed "Planned minutes" until the first kick-off. Its
figures there are the line-up costed at a full period each, which is not
time anyone has played — and the numbers themselves cannot say which they
are, so the heading does.
"Show subs" folded the bench strip away, which was never the strip anyone
wanted rid of. It now folds the substitutions out of the timeline instead,
leaving the goals; a rotated squad buries them among swaps nobody is
scrolling back for. The bench is always drawn.
"Next line-up" leaves the clock controls for the foot of the "Changes at
half-way" card, and the dialog that used to ask first goes with it: the
list it now sits under is what that dialog was there to say.
That only holds if the list is true, and it was not. Play overtakes a plan:
once the player a planned swap takes off has gone off live, the difference
between the two line-ups still names their slot but proposes withdrawing
whoever came on for them. Those swaps are dropped from the card — and from
what the button does, so an injury replacement keeps the place for the rest
of the half instead of lasting exactly one quarter. AdvancePeriodAsync
applies PlannedChangesReport's answer rather than forming a second one,
because a card promising one thing while the button under it does another
is worse than either behaviour alone.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01AfrvWcNR8hMjw3ny6dMemX