Skip to content

Potential fix for code scanning alert no. 243: Setting a DACL to NULL in a SECURITY_DESCRIPTOR #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JaviLendi wants to merge 1 commit into from
Closed

Potential fix for code scanning alert no. 243: Setting a DACL to NULL in a SECURITY_DESCRIPTOR #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/utils/WinUtil.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,14 +565,20 @@ static void ResetRegKeyAcl(HKEY hkey, const char* keyName) {
return;
}
SECURITY_DESCRIPTOR secdesc;
InitializeSecurityDescriptor(&secdesc, SECURITY_DESCRIPTOR_REVISION);
if (!InitializeSecurityDescriptor(&secdesc, SECURITY_DESCRIPTOR_REVISION)) {
RegCloseKey(hKey);
return;
}

#pragma warning(push)
#pragma warning(disable : 6248)
// "Setting a SECURITY_DESCRIPTOR's DACL to nullptr will result in an unprotected object"
// https://docs.microsoft.com/en-us/cpp/code-quality/c6248?view=msvc-170
SetSecurityDescriptorDacl(&secdesc, TRUE, nullptr, TRUE);
#pragma warning(pop)
ACL dacl;
if (!InitializeAcl(&dacl, sizeof(dacl), ACL_REVISION)) {
RegCloseKey(hKey);
return;
}
if (!SetSecurityDescriptorDacl(&secdesc, TRUE, &dacl, FALSE)) {
RegCloseKey(hKey);
return;
}

RegSetKeySecurity(hKey, DACL_SECURITY_INFORMATION, &secdesc);
RegCloseKey(hKey);
Expand Down
Loading