refactor(cleanup): remove dead code + no-op calibration dimension (P1.4, P1.6)#60
Merged
Conversation
Closes #50, #52 (P1.4, P1.6). #50 dead code (verified 0 production callers): - delete src/quant/alternative_bars.py (+ its test) — orphaned. - delete RecStore.get_sector_win_rates — unused and buggy (GROUP BY style while the docstring/return claimed per-sector). - delete OvernightRiskProfile.to_context_str (+ its test) — built but never called (the live to_context_str on IntelChain is unaffected). - delete the DEPRECATED PROFESSIONAL_/QUICK_ANALYSIS_FRAMEWORK prompt constants — superseded by the v7.0 seven-dimension framework. #52 stubs behind advertised features: - ConfidenceCalibrator advertised a per-sector calibration dimension that always returned 0.0; remove the dead dimension and method, keep the (reserved) sector param, and document it honestly. Behavior-preserving (it contributed 0.0). - make LiveBroker's simulation-only-by-design status explicit in its docstring and NotImplementedError messages. ruff clean; affected suites (366 tests) green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Jcstack
enabled auto-merge (squash)
June 25, 2026 16:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50, closes #52.
#50 — dead code (all verified 0 production callers before removal)
src/quant/alternative_bars.py(+ test) — orphaned module.RecStore.get_sector_win_rates— unused and buggy (GROUP BY stylewhile the docstring claimed per-sector).OvernightRiskProfile.to_context_str(+ test) — built but never called. (The liveto_context_stronIntelChain, used byrecommendation_service, is untouched.)PROFESSIONAL_ANALYSIS_FRAMEWORK/QUICK_ANALYSIS_FRAMEWORKprompt constants — superseded by the v7.0 seven-dimension framework.#52 — stubs behind advertised features
ConfidenceCalibratoradvertised a per-sector calibration dimension that always returned 0.0. Removed the dead dimension + method; kept the (now-reserved)sectorparam and documented it honestly. Behavior-preserving (it contributed exactly 0.0).LiveBroker's simulation-only-by-design status explicit in its docstring +NotImplementedErrormessages.Verified
ruff check+ruff format --checkclean; import smoke + 366 related tests green (overnight-risk, recommendation, calibrator, broker, quant, prediction).No behavior change. Simulation-only project; not investment advice.