Skip to content

More SimpleValue types are handled#21

Open
fbrosseau wants to merge 2 commits into
JeffCyr:masterfrom
fbrosseau:more-simplevalue-types
Open

More SimpleValue types are handled#21
fbrosseau wants to merge 2 commits into
JeffCyr:masterfrom
fbrosseau:more-simplevalue-types

Conversation

@fbrosseau

Copy link
Copy Markdown
Contributor
  • Add ToArray to ClrDynamic
  • Add support for X509Certificate(2)
  • Add support for IPEndPoint

Francis Brosseau added 2 commits February 1, 2019 10:56
- Add support for X509Certificate(2)
- Add support for IPEndPoint
@fbrosseau fbrosseau force-pushed the more-simplevalue-types branch from 92d2dda to 87d20d5 Compare February 1, 2019 16:15
@JeffCyr

JeffCyr commented Feb 5, 2019

Copy link
Copy Markdown
Owner

Thanks for thoses changes, there is some nice ideas.

However I don't want to add too much stuff in SimpleValue, theses should only be primitive types, I added some more common types (TimeSpan, DateTime, etc) but it's a bit of a stretch already. An extensible ClrDynamic.ConvertTo<T>() method could make more sense here to add more complex types.

ToArray

I think ClrDynamic.ToArray should limit itself to primitive array types for now. I don't like the idea of mixing Visualizers in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants