More SimpleValue types are handled#21
Open
fbrosseau wants to merge 2 commits into
Open
Conversation
fbrosseau
commented
Feb 1, 2019
Contributor
- Add ToArray to ClrDynamic
- Add support for X509Certificate(2)
- Add support for IPEndPoint
added 2 commits
February 1, 2019 10:56
- Add support for X509Certificate(2) - Add support for IPEndPoint
92d2dda to
87d20d5
Compare
Owner
|
Thanks for thoses changes, there is some nice ideas. However I don't want to add too much stuff in SimpleValue, theses should only be primitive types, I added some more common types (TimeSpan, DateTime, etc) but it's a bit of a stretch already. An extensible ToArrayI think ClrDynamic.ToArray should limit itself to primitive array types for now. I don't like the idea of mixing Visualizers in there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.