Refactored to eliminate static ServiceModelConfig due to failing afte…#12
Open
bvandehey wants to merge 1 commit intoJeffGos:masterfrom
Open
Refactored to eliminate static ServiceModelConfig due to failing afte…#12bvandehey wants to merge 1 commit intoJeffGos:masterfrom
bvandehey wants to merge 1 commit intoJeffGos:masterfrom
Conversation
…r 160 instances created.
Author
|
Here's a simple program that replicates the failure at 160 requests: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UrbanAirSharp library fails after 160 requests if your program creates a new instance of the UrbanAirshipGateway for each request. Due to our multi-tenant application, this is a requirement. The reason it fails is due to the static ServiceModelConfig class which contains a static reference to the HttpClient class. I have refactored the code to change ServiceModelConfig from a static class to an instance class which eliminates this issue.