Skip to content

mcdj: add ci workflow#161

Merged
baltzell merged 4 commits into
mainfrom
mcdj-ci
May 13, 2026
Merged

mcdj: add ci workflow#161
baltzell merged 4 commits into
mainfrom
mcdj-ci

Conversation

@baltzell
Copy link
Copy Markdown
Contributor

@baltzell baltzell commented Apr 15, 2026

No description provided.

@baltzell baltzell changed the title Add GitHub Actions workflow for mcdj add ci workflow for mcdj Apr 15, 2026
@baltzell baltzell changed the title add ci workflow for mcdj mcdj: add ci workflow Apr 15, 2026
@baltzell baltzell marked this pull request as ready for review April 17, 2026 17:08
@baltzell baltzell enabled auto-merge (squash) April 19, 2026 00:29
c-dilks
c-dilks reviewed Apr 24, 2026
View reviewed changes
Comment thread .github/workflows/mcdj.yml Outdated
@baltzell
Copy link
Copy Markdown
Contributor Author

baltzell commented May 7, 2026

@c-dilks We still can't build containers at code.jlab.org, right?

@c-dilks
Copy link
Copy Markdown
Member

c-dilks commented May 7, 2026

@c-dilks We still can't build containers at code.jlab.org, right?

We could build, but AFAIK the cleanup policy in container-forge still causes issues...

If you need an image with GEMC now, use either Mauri's or my old prototype image

codecr.jlab.org/dilks/phoenix-magnion/phoenix_magnion:latest

However it's v5.12 and lacks clas12-mcgen and coatjava.

@baltzell
Copy link
Copy Markdown
Contributor Author

baltzell commented May 12, 2026

looks like it worked

@c-dilks
Copy link
Copy Markdown
Member

c-dilks commented May 13, 2026

Yes, but that was last week

  • container-forge/simulation:latest was available last week, but currently it is not
  • you're also only testing -h

c-dilks
c-dilks requested changes May 13, 2026
View reviewed changes
Comment thread .github/workflows/mcdj.yml Outdated
@baltzell @c-dilks
Update .github/workflows/mcdj.yml
adb8b0c 
Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>
@baltzell baltzell assigned c-dilks and unassigned raffaelladevita May 13, 2026
@c-dilks
Copy link
Copy Markdown
Member

c-dilks commented May 13, 2026

Weird. The simulation:latest image is not even available in the container-forge container registry, since we wiped the whole registry 1.5 weeks ago and we can't even get that far in the CI image build pipeline anyway; however, you get successful workflow runs here since I guess all of our "deleted" images somehow still exist.

c-dilks
c-dilks approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@c-dilks c-dilks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your next PR should actually run a simulation + reconstruction job :)

@baltzell baltzell merged commit 92ffcfd into main May 13, 2026
2 checks passed
@c-dilks c-dilks deleted the mcdj-ci branch May 13, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c-dilks c-dilks c-dilks approved these changes

Assignees

@c-dilks c-dilks

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baltzell @c-dilks @raffaelladevita