feat: add decoding engine - #1220
Closed
baltzell wants to merge 26 commits into
Closed
Conversation
baltzell
force-pushed
the
decoding-engine
branch
from
April 23, 2026 01:39
5362ff2 to
a9eb2e6
Compare
baltzell
marked this pull request as ready for review
April 23, 2026 19:01
baltzell
requested review from
c-dilks,
raffaelladevita and
zieglerv
as code owners
April 23, 2026 19:01
baltzell
force-pushed
the
decoding-engine
branch
from
April 23, 2026 23:13
f75d9dd to
a99234f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past year, the decoder was sped up enough to be usable as the (single-threaded) CLARA I/O service
DecoderReader. With current reconstruction speeds, that scales linearly up to about 32 threads, where it becomes I/O-bound by (single-threaded) decoding.This pull request implements the decoder as a (multi-threaded) CLARA engine
DecoderEngine, based on a pool ofCLASDecoderobjects, in lieu of a thread-safe decoder. To minimize initialization overhead and logging noise, a single decoder'sConstantManagerobjects are shared by the whole pool, similar toReconstructionEngine. This is achieved via new "share" constructors forCLASDecoderandDetectorEventDecoder.Here's the rough performance for a 24-thread job on clara2502 with
etc/services/rgd-clarode.yml. Note, the 12-ms-per-event for the DECO engine suggests some thread contention, e.g., synchronizedConstantsManagercalls, since it's few-ms when run single-threaded.