Harden translated information tooltips - #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Information help was visually present but some assistive labels remained English, long translated copy could be clipped, and touch browsers did not have a dependable focus path. A documentation review also found old descriptions of Scott's preset and VMAF cost after the current per-library and hardware-tone-map work.
User impact
Help text is now translated, keyboard- and touch-reachable, programmatically associated, and contained within the viewport. The wording accurately distinguishes optional VMAF sampling and the selectable software/supported-hardware HDR tone-map engine. No settings or defaults change.
Validation
dotnet build Optimisarr.slnx --no-restore -warnaserror— 0 warningsdotnet test Optimisarr.slnx --no-build --no-restore— 1,487 passednpm run check— cleannpm run build— passednpm run test:e2e— 46 passedpython3 scripts/check_docs.py— passedpython3 scripts/check_openapi.py— current