Keep Personal quality checks on concrete preset qualities - #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Personal quality checks now compare each video preset at its concrete configured
quality without recursively running Adaptive per-title VMAF inside every
12-second scene.
Normal optimisation jobs retain Adaptive per-title VMAF. Preview jobs also
retain it so a requested Preview can still reflect the library's selected
quality path.
Root cause
The dispatcher started adaptive quality selection for every video re-encode
whose library used
AdaptiveVmaf. Calibration jobs are deliberately associatedwith their library so they can resolve each complete preset, which unintentionally
made every one of their planned scene jobs eligible for another
early/middle/late adaptive search.
For an 8-bit video check, 4 presets × 3 scenes × up to 4 qualities × 3 adaptive
windows could prepare as many as 144 redundant 40-second encode-and-score
passes before producing the intended clips.
What changed
VMAF evidence
Safety
Calibration remains disposable and replacement-ineligible. This change removes
preparation work; it does not weaken structural verification, alter normal-job
VMAF gates, or permit any source mutation.
Validation
dotnet build Optimisarr.slnx --configuration Release --warnaserror— zero warnings
dotnet test Optimisarr.slnx --configuration Release --no-build— 1,489 passed
entered the nested adaptive search while its session progress remained near 4%