Fix Personal quality preset fidelity and mobile grading bay - #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/api/library-options, and make the library slider restore the full selected bundle when moving away from Scott's Settings.Why
A library carrying Scott's Settings could leak its HDR tone-map, AAC 96 kbps, and stereo-downmix overrides into Conservative HEVC, AV1, and H.264 comparison candidates. That made nominally different candidates encode with the same effective bundle. Separately,
aspect-videoplus a fixed minimum height silently produced a 455 px player inside a 390 px viewport; the parent clipped it, so page-level overflow checks missed the defect.Safe MP4-to-MKV fallback remains unchanged: retained image subtitles can still require MKV rather than being discarded.
User impact
Personal quality candidates are genuinely distinct and revealed recommendations persist the exact preset the user judged. The comparison player now remains fully visible and touch-friendly on phones, short landscape screens, and fullscreen.
Validation
dotnet build Optimisarr.slnx --no-restore -warnaserror— 0 warnings, 0 errorsdotnet test Optimisarr.slnx --no-build— 1,493 passednpm run check— 0 errors, 0 warnings; 8 locales auditednpm run build— passednpx playwright test— 48 passedpython3 scripts/check_docs.py— passedpython3 scripts/check_openapi.py --configuration Release --no-build— up to date