test(mcp): add tests for intent-pattern-checks and taskmaestro-detector (#1181)#1186
Merged
Merged
Conversation
…or (#1181) - Add 76 tests for INTENT_PATTERN_CHECKS covering structure, priority ordering, false positive prevention, and all 13 domain patterns - Add 7 tests for isTaskmaestroAvailable covering present/absent/error cases - Verify first-match-wins priority prevents greedy pattern false positives
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: APPROVE
CI Status: PASS (25/25 checks)
Code Quality
- No
anytypes, no unused imports, no dead code - Test-only PR verified: only
.spec.tsfiles added, zero source changes - Well-structured:
describeblocks by concern (structure, priority, false-positive, domains) - Proper mock cleanup with
afterEach(() => vi.restoreAllMocks())
Spec Compliance (issue #1181)
- All 13 domain patterns tested (parameterized + individual)
- Priority ordering verified (exact order + pairwise assertions)
- False positive prevention covered (agent name mentions vs domain keywords)
- taskmaestro-detector: present/absent/EACCES/non-Error/custom-homedir/call-count
- No source file changes
Issues Found
None.
Recommendation: APPROVE
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
✅ Review complete - review agent approved
CI Status: ALL PASS (25/25)
Review: APPROVE — 0 issues found
Checklist:
- No source file modifications (test-only PR)
- intent-pattern-checks tests cover 13 domain patterns
- taskmaestro-detector tests cover present/absent/error cases
- All CI checks pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan