feat(cli): add completion command with bash/zsh/fish support (#1179)#1187
Merged
Conversation
Add `codingbuddy completion <shell>` command that outputs shell-specific completion scripts for bash, zsh, and fish. Includes dynamic plugin name completion for update/uninstall commands via .codingbuddy/plugins.json. Closes #1179
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: APPROVE
CI Status: PASS (25/25 checks)
Code Quality
- No
anytypes, no unused imports, no dead code - Clean architecture: single
completion.tswith data, generators, dispatcher, handler - Proper error handling in
getPluginNames(missing file + parse error) andrunCompletion(missing/unsupported shell) - Shell scripts use runtime
grep/sedfor plugin names — no injection risk at generation time - Good decision to consolidate bash/zsh/fish generators into single file vs issue's proposed 3 separate files
Spec Compliance (issue #1179)
-
codingbuddy completion bashoutputs valid bash completion script -
codingbuddy completion zshoutputs valid zsh completion script -
codingbuddy completion fishoutputs valid fish completion script - Dynamic plugin name completion for update/uninstall
- CLI routing + help text updated
- All tests pass
Test Coverage
- Data structures, dynamic plugin names (3 cases), bash/zsh/fish generators (4 each), dispatcher (4 cases), runCompletion (5 cases), CLI parsing (2 cases) = 30+ test cases
Issues Found
None.
Recommendation: APPROVE
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
✅ Review complete - review agent approved
CI Status: ALL PASS (25/25)
Review: APPROVE — 0 issues found
Checklist:
- bash/zsh/fish completion scripts generate correctly
- Dynamic plugin name completion works
- CLI routing wired up properly
- All tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codingbuddy completion bash/zsh/fishcommandTest plan