Skip to content

feat(cli): add completion command with bash/zsh/fish support (#1179)#1187

Merged
JeremyDev87 merged 1 commit into
masterfrom
taskmaestro/1775205842/pane-1
Apr 3, 2026
Merged

feat(cli): add completion command with bash/zsh/fish support (#1179)#1187
JeremyDev87 merged 1 commit into
masterfrom
taskmaestro/1775205842/pane-1

Conversation

@JeremyDev87

Copy link
Copy Markdown
Owner

Summary

Test plan

  • Unit tests for completion data structure
  • Unit tests for bash/zsh/fish script generation
  • Integration test for CLI command routing

Add `codingbuddy completion <shell>` command that outputs shell-specific
completion scripts for bash, zsh, and fish. Includes dynamic plugin name
completion for update/uninstall commands via .codingbuddy/plugins.json.

Closes #1179
@vercel

vercel Bot commented Apr 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
codingbuddy-landing Ready Ready Preview, Comment Apr 3, 2026 9:38am

@JeremyDev87 JeremyDev87 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: APPROVE

CI Status: PASS (25/25 checks)

Code Quality

  • No any types, no unused imports, no dead code
  • Clean architecture: single completion.ts with data, generators, dispatcher, handler
  • Proper error handling in getPluginNames (missing file + parse error) and runCompletion (missing/unsupported shell)
  • Shell scripts use runtime grep/sed for plugin names — no injection risk at generation time
  • Good decision to consolidate bash/zsh/fish generators into single file vs issue's proposed 3 separate files

Spec Compliance (issue #1179)

  • codingbuddy completion bash outputs valid bash completion script
  • codingbuddy completion zsh outputs valid zsh completion script
  • codingbuddy completion fish outputs valid fish completion script
  • Dynamic plugin name completion for update/uninstall
  • CLI routing + help text updated
  • All tests pass

Test Coverage

  • Data structures, dynamic plugin names (3 cases), bash/zsh/fish generators (4 each), dispatcher (4 cases), runCompletion (5 cases), CLI parsing (2 cases) = 30+ test cases

Issues Found

None.

Recommendation: APPROVE

@JeremyDev87 JeremyDev87 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Review complete - review agent approved

CI Status: ALL PASS (25/25)

Review: APPROVE — 0 issues found

Checklist:

  • bash/zsh/fish completion scripts generate correctly
  • Dynamic plugin name completion works
  • CLI routing wired up properly
  • All tests pass

@JeremyDev87 JeremyDev87 added feat cli CLI commands and interfaces labels Apr 3, 2026
@JeremyDev87 JeremyDev87 self-assigned this Apr 3, 2026
@JeremyDev87 JeremyDev87 merged commit 540b3ed into master Apr 3, 2026
25 checks passed
@JeremyDev87 JeremyDev87 deleted the taskmaestro/1775205842/pane-1 branch April 3, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli CLI commands and interfaces feat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(cli): add completion command with bash/zsh/fish support

1 participant