feat(mcp): activate rule event tracking in core handlers (#1180)

[JeremyDev87]

Summary

• Activate event collection in 5 core MCP handlers
• Events written to rule-stats.json via RuleStatsWriterService
• Fire-and-forget pattern for zero latency impact
• Closes feat(mcp): activate rule event tracking in core handlers #1180

Test plan

• Integration tests for event emission in each handler
• Verify existing handler tests still pass
• Verify rule-stats.json writes

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
codingbuddy-landing	Ready	Preview, Comment	Apr 3, 2026 9:41am

[JeremyDev87]

Review: APPROVE

CI Status: PASS (25/25 checks)

Code Quality

• No any types, no unused imports, no dead code
• Consistent fire-and-forget pattern across all 5 handlers: try { record() } catch { /* never break */ }
• Handler return values unchanged — events recorded after result computation, before return
• RuleEventCollector injected via constructor DI in all handlers
• One as type assertion in quality-report.handler.ts for result.domains — acceptable for dynamic service return

Spec Compliance (issue #1180)

• parse_mode → mode_activated event with mode + agent details
• generate_checklist → checklist_generated event per domain
• dispatch_agents → specialist_dispatched event per primary + parallel agent
• pr_quality_report → specialist_dispatched event per detected domain
• agent_discussion → specialist_dispatched event per specialist
• All existing tests pass

Test Coverage (16 new tests)

• Each handler has: normal emission, no events on failure, handler resilience when record throws
• agent.handler has additional parallel dispatch test
• Integration spec and mcp.service.spec properly updated with mock

Issues Found

None.

Recommendation: APPROVE

[JeremyDev87]

✅ Conductor Review — APPROVE

CI Status: ALL PASS (25/25)

Review: APPROVE — 0 issues found

Verification against PLAN:

• parse_mode → mode_activated event with mode + agent
• generate_checklist → checklist_generated per domain
• dispatch_agents → specialist_dispatched per agent (primary + parallel)
• pr_quality_report → specialist_dispatched per detected domain
• agent_discussion → specialist_dispatched per specialist

Code Quality:

• Fire-and-forget pattern: try/catch blocks, never breaks handler
• No any types
• No unused imports
• All existing tests pass with added RuleEventCollector mock
• New tests: 3 per handler (success/failure/throws)
• Constructor DI consistent across all handlers