refactor: embed memory feedback rules into project rules and skills (#1189)#1195
Merged
Conversation
…1189) Migrate 13 feedback rules from personal memory into shared project rules/skills so all users benefit from accumulated best practices. Changes across 5 files: A. taskMaestro SKILL.md (3 items): - Default --review-pane to disabled; Conductor Review is primary - Add Mandatory PR Rules (--add-label requirement) to assign template - Add CI gate check to Conductor Review checklist B. Core Rules (3 items): - Add Branch Discipline section (never commit to master/main) - Add Mode Transition Rules (PLAN→ACT requires explicit user input) - Strengthen Error Recovery (recoverable vs unrecoverable classification) C. Systematic Debugging Skill (3 items): - Add mandatory 6-step debugging sequence - Add Validate First rule (run validate/check before debugging) - Add Verify Mental Model rule (read official docs before assuming) D. Ship Skill (2 items): - Add security check must run across ALL workspaces - Add CI workflow self-inclusion check for paths filters E. Parallel Execution Rules (2 items): - Add implementation vs read-only task dispatch rule (taskMaestro vs subAgents) - Add monorepo path safety rule (absolute paths / git -C) Closes #1189
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Remove the second AgentStack interface (lines 190-197) that conflicted with the first (lines 6-17). The duplicate used 'specialists' and optional 'tags', while the schema and JSON files use 'specialist_agents' and required 'tags'. Unified all references to use 'specialist_agents' consistently: - agent-stack.service.ts: isValidStack and toSummary - agent-stack.service.spec.ts: mock data - agent.handler.ts: stack resolution - agent.handler.spec.ts: mock stack data
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
✅ Conductor Review — APPROVE
CI: 25/25 ALL PASS
Review: APPROVE — 0 issues
Plan Verification (#1189 — 13 items across 5 files):
- A1: --review-pane default disabled, Conductor Review as primary
- A2: Mandatory PR label rules in assign template
- A3: CI check in Conductor Review checklist
- B1: Branch Discipline in core.md
- B2: Mode Transition Rules (PLAN wait + ACT autonomous)
- B3: Error Recovery (auto-try alternatives)
- C1-C3: Debugging 6-step sequence + validate first + verify mental model
- D1-D2: Ship full security check + CI paths awareness
- E1-E2: subAgent restriction + monorepo path safety
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate 13 feedback rules from personal memory into shared project rules/skills so all users benefit from accumulated best practices.
--review-paneto disabled (Conductor Review as primary), add Mandatory PR Rules (--add-label), add CI gate to Conductor ReviewTest plan
yarn prettier --write— no formatting issuesyarn workspace codingbuddy lint --fix— 0 errors (1 pre-existing warning)yarn workspace codingbuddy test— 5808 tests passed (234 files)Closes #1189