fix(mcp): unify AgentStack schema — specialist_agents vs specialists drift (#1196)#1203
Merged
Merged
Conversation
…ma (#1196) Verify all preset JSON files conform to Zod schema and use the canonical specialist_agents field. Guard against schema drift regression.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
✅ Conductor Review — APPROVE
CI: 25/25 ALL PASS (type-check ✅, build ✅)
Review: APPROVE — 0 issues
Plan Verification (#1196 P0):
- type-check passes (AgentStack interface conflict resolved)
- build passes
- Integration test: all 6 preset JSONs validated against Zod schema
- Regression test:
specialistsfield correctly rejected (onlyspecialist_agentsaccepted) - Drift prevention: future presets auto-validated by CI
Note:
The type conflict itself was resolved in Wave 3 PR #1194 merge. This PR adds CI-enforced integration tests to prevent recurrence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentStackSchemawith canonicalspecialist_agentsfieldspecialistsfield (the wrong name from the schema drift)b86ae4eandd54a95a— this PR adds the missing integration test guard (TASK.md Step 7)Closes #1196
Test plan
yarn typecheckpassesyarn buildpassesyarn test— 5816 tests pass (8 new integration tests added)specialists(wrong name) is rejected