fix(tui): add hybrid polling safety net to HUD bridge (#1204)#1208
Merged
Conversation
Run polling alongside fs.watch simultaneously so that silent watcher failures (containers, restricted FS) never stall HUD/TUI sync. - Default pollIntervalMs 1000 → 200 for faster detection - startPollingFallback accepts silent param for hybrid mode - fs.watch error handler only cleans up watcher (polling already active) - Tests use pollIntervalMs:50 for environment independence - New test verifies both watcher and poll are active in hybrid mode
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
✅ Review complete — all comments addressed
Code Review:
- Hybrid polling:
startPollingFallback(true)called instart()alongsidefs.watch— correct design silentparameter prevents stderr noise in normal hybrid mode- Default
pollIntervalMs1000→200 — appropriate for HUD sync latency - Tests:
pollIntervalMs: 50for environment independence, new hybrid mode test scheduleProcess()debounce +processChange()prev comparison prevents duplicate events- No unused imports, no dead code
- CI: 25/25 checks pass
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fs.watchsimultaneously (hybrid mode) so silent watcher failures never stall HUD/TUI syncpollIntervalMsfrom 1000ms to 200ms for faster event detectionstartPollingFallbackacceptssilentparam — hybrid mode runs silently, explicit error logs warningpollIntervalMs: 50for environment independenceTest plan
Closes #1204