feat(plugin): add runtime mode detection utility (#1211)#1217
Merged
Conversation
New hooks/lib/runtime_mode.py with detect_runtime_mode() and is_mcp_available() — checks ~/.claude/mcp.json for codingbuddy MCP server entry to distinguish MCP vs standalone environments. Gracefully handles missing file, parse errors, and absent keys. 8 pytest cases cover all detection paths.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
✅ Review complete — all comments addressed
Code Review:
runtime_mode.py: clean utility withdetect_runtime_mode()+is_mcp_available()- Case-insensitive key matching for
mcp.jsonentries - Graceful fallback to "standalone" on all error paths
test_runtime_mode.py: 8 tests covering mcp detection, standalone fallback, parse errors, missing file- No unused imports, no dead code
- CI: 28/28 checks pass
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hooks/lib/runtime_mode.pywithdetect_runtime_mode()andis_mcp_available()~/.claude/mcp.jsonfor codingbuddy MCP server entry"mcp"or"standalone"— gracefully handles missing file, parse errors, absent keysTest plan
Closes #1211