fix(plugin): improve buddy rendering alignment for wide characters#1220
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
display_width,pad_to_display_width,truncate_to_display_width,truncate_left_to_display_width) usingunicodedatarender_face_banner,render_section_header, andrender_box_linehelpersfacevariable shadowing inrender_session_summarythat caused wrong face in farewell lineTest plan
test_render_buddy_face_box_scales_for_longer_face— verifies top rule width matches custom facetest_render_session_summary_farewell_keeps_buddy_face_when_agents_exist— verifies farewell uses buddy face, not agent facetest_box_lines_share_same_display_width_for_wide_text— verifies Intelligence Report alignment with Korean texttest_impact_report_box_aligns_with_wide_text— verifies Impact Report alignment with Korean texttest_custom_face_banner_keeps_top_and_bottom_aligned— verifies onboarding tour banner alignment