feat(plugin): add standalone readiness diagnostics to health check (#1215)#1221
Merged
Merged
Conversation
…1215) Add 3 new checks to HealthChecker (8-10): - check_mcp_connection: detect codingbuddy entry in mcp.json - check_runtime_mode: report mcp vs standalone via runtime_mode - check_standalone_readiness: verify .ai-rules, ModeEngine, hooks run_all() now returns 10 results. Includes 6 new tests covering all scenarios (PASS/WARN for each check, run_all count). Closes #1215
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
✅ Review complete — all comments addressed
Code Review:
- Check 8
check_mcp_connection(): reads mcp.json, case-insensitive key match — correct - Check 9
check_runtime_mode(): delegates to runtime_mode utility — clean - Check 10
check_standalone_readiness(): checks .ai-rules, ModeEngine import, UserPromptSubmit — comprehensive run_all()updated to 10 checks- Tests cover MCP configured/missing, standalone ready/not-ready scenarios
- No unused imports, docstrings updated
- CI: 28/28 checks pass
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_mcp_connection()— detects codingbuddy entry inmcp.json(PASS/WARN)check_runtime_mode()— reportsmcporstandaloneviaruntime_mode.detect_runtime_mode()check_standalone_readiness()— verifies.ai-rules/,ModeEngine, andUserPromptSubmithookrun_all()to return 10 checks (was 7)Test plan
python3 -m pytest tests/test_health_check.py -v— 28/28 passedyarn workspace codingbuddy build— successyarn workspace codingbuddy test— 5822 passedCloses #1215