feat(plugin): conditional prompt injection for MCP/standalone (#1213)#1222
Merged
Conversation
Branch build_system_prompt by runtime mode: MCP mode injects parse_mode + dispatch enforcement rules, standalone mode uses hook-based instructions without referencing MCP-only tools. - Import is_mcp_available from runtime_mode - Add _BASE_RULES_STANDALONE for non-MCP environments - dispatchEnforcement section only in MCP mode - 7 new tests: standalone (5) + explicit MCP (2) - All 37 prompt_injection + runtime tests pass
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
✅ Review complete — all comments addressed
Code Review:
_BASE_RULES_STANDALONE: "follow mode hook output" instead of "MUST call parse_mode" — correctis_mcp_available()import and runtime branching inbuild_system_prompt()— clean_DISPATCH_ENFORCEMENTMCP-only gated — correct- Existing tests preserved via
autousemock fixture (is_mcp_available=True) - New
TestStandaloneModeclass with MCP-unavailable scenarios - No unused imports, no dead code
- CI: 28/28 checks pass
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_system_promptby runtime mode: MCP injectsparse_mode+ dispatch enforcement, standalone uses hook-based instructionsis_mcp_availablefromruntime_mode(from feat(plugin): add runtime mode detection utility (standalone vs MCP) #1211)_BASE_RULES_STANDALONE— references mode detection hook instead of MCP-onlyparse_modetooldispatchEnforcementsection only injected in MCP modeTest plan
Closes #1213