feat(plugin): first-session restart UX and enriched standalone output (#1214)#1223
Merged
Conversation
…#1214) session-start.py: - Add i18n "restart_needed" message to all 5 languages - Print restart hint when hook is newly installed so users know mode detection activates on next session user-prompt-submit.py: - Import runtime_mode.is_mcp_available() for MCP/standalone detection - MCP mode: minimal output (mode header + parse_mode hint) - Standalone mode: full enriched ModeEngine.build_instructions() output - Fallback: minimal output if imports fail Tests: - 3 new tests for restart message (i18n keys, new install output, no output when already installed) - 3 new tests for MCP vs standalone output branching
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
✅ Review complete — all comments addressed
Code Review:
- session-start.py:
restart_neededi18n message added in all 5 languages (en, ko, ja, zh, es) - Message shown only when
installed_hook=True(new install, not re-register) - user-prompt-submit.py: MCP/standalone branching with runtime_mode
- Tests: TestRestartMessage class with i18n key validation + new install output test
- No unused imports, clean integration with existing i18n system
- CI: 28/28 checks pass
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runtime_mode.is_mcp_available()to branch output:# Mode: X+ parse_mode guidance (let MCP handle enrichment)ModeEngine.build_instructions()outputCloses #1214
Test plan
python3 -m pytest hooks/test_session_start.py hooks/test_user_prompt_submit.py -v— 67 tests passedyarn lintpassesyarn typecheckpassesyarn testpasses (71 vitest tests)