fix(plugin): correct AUTO mode default agent id to auto-mode (#1226)#1227
Merged
Conversation
DEFAULT_AGENTS used 'auto-mode-agent' for AUTO mode but the canonical id is 'auto-mode' (matching keyword.types.ts and auto-mode.json). This caused _load_agent_details to return None, skipping enrichment.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
✅ Review complete — all comments addressed
Code Review:
mode_engine.py:auto-mode-agent→auto-mode— matches canonical id in keyword.types.ts and agents/auto-mode.jsontest_mode_engine.py: assertion updated to match- Minimal, focused change — no side effects
- CI: 28/28 checks pass
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mode_engine.pyDEFAULT_AGENTS의 AUTO 모드 agent id를auto-mode-agent에서auto-mode로 수정test_mode_engine.py의 assertion도 동일하게 수정Problem
auto-mode-agent는 canonical id(auto-mode)와 불일치하여_load_agent_details()가 None을 반환, AUTO 모드에서 agent enrichment이 누락됨.Closes #1226
Test plan
python3 -m pytest hooks/lib/test_mode_engine.py -v— 37 passedyarn workspace codingbuddy typecheck— passyarn workspace codingbuddy test— 5822 passed