fix(plugin): extend runtime_mode to check settings.json and project .mcp.json (#1224)#1228
Merged
Merged
Conversation
…mcp.json (#1224) - Add project_dir parameter to detect_runtime_mode() and is_mcp_available() - Check 3 locations in order: mcp.json → settings.json → project .mcp.json - Extract _check_mcp_json() and _check_settings_json() helper functions - Add 18 new tests covering settings.json, project .mcp.json, priority order Closes #1224
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
✅ Review complete — all comments addressed
Code Review:
- 3-path detection:
~/.claude/mcp.json→~/.claude/settings.json→{project}/.mcp.json— correct order _check_mcp_json()and_check_settings_json()extracted as helpers — clean DRYproject_dirparam added to bothdetect_runtime_mode()andis_mcp_available()- All error paths return False (graceful fallback)
- Tests: settings.json detection, project .mcp.json detection, all-empty → standalone
- Existing tests preserved and passing
- CI: 28/28 checks pass
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detect_runtime_mode()to check 3 locations in priority order:~/.claude/mcp.json→~/.claude/settings.json→{project}/.mcp.jsonproject_dirparameter to bothdetect_runtime_mode()andis_mcp_available()_check_mcp_json()and_check_settings_json()helper functionsTest plan
Closes #1224