Skip to content

fix(plugin): use resolve_data_dir in notifications (#1231) #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JeremyDev87 merged 1 commit into from
Apr 3, 2026
Merged

fix(plugin): use resolve_data_dir in notifications (#1231) #1233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/claude-code-plugin/hooks/lib/notifications.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
from urllib.request import Request, urlopen, build_opener, HTTPRedirectHandler
from urllib.error import URLError

from data_dir import resolve_data_dir


class _NoRedirectHandler(HTTPRedirectHandler):
"""Refuse all HTTP redirects to prevent secret leakage."""
Expand Down Expand Up @@ -139,7 +141,7 @@ def notify(
Args:
event: The notification event to send.
config: Parsed codingbuddy.config.json (event toggles + platform list).
secrets_dir: Override secrets directory (default: ~/.codingbuddy).
secrets_dir: Override secrets directory (default: resolve_data_dir()).

Returns:
Dict mapping platform name -> success boolean.
Expand All @@ -149,7 +151,7 @@ def notify(
return {}

if secrets_dir is None:
secrets_dir = os.path.join(os.path.expanduser("~"), ".codingbuddy")
secrets_dir = resolve_data_dir()

secrets = load_secrets(secrets_dir)
notifications = config.get("notifications", {})
Expand Down
Loading