fix(plugin): use resolve_data_dir in onboarding skip message (#1232)#1234
Merged
Conversation
TOUR_SKIP hardcoded ~/.codingbuddy/onboarded but the actual flag file uses resolve_data_dir() which respects CLAUDE_PLUGIN_DATA. Replaced the static dict with get_tour_skip_message() so the skip instructions always show the correct path.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
✅ Review complete — all comments addressed
Code Review:
onboarding_tour.py:TOUR_SKIPdict →get_tour_skip_message()function usingresolve_data_dir()render_onboarding_tour()caller updated- Tests: default path test +
CLAUDE_PLUGIN_DATAcustom path test - 5 languages all dynamically generated
- CI: 28/28 checks pass
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TOUR_SKIP정적 dict를get_tour_skip_message()함수로 교체하여resolve_data_dir()사용CLAUDE_PLUGIN_DATA환경변수 설정 시 올바른 경로가 skip 메시지에 반영됨TestGetTourSkipMessage테스트 클래스 추가 (4개 테스트)Problem
TOUR_SKIP이~/.codingbuddy/onboarded를 하드코딩하여,CLAUDE_PLUGIN_DATA설정 시 사용자가 잘못된 경로를 touch → 투어가 계속 반복되는 문제.Closes #1232
Test plan
python3 -m pytest tests/test_onboarding_tour.py -v— 28 passedyarn workspace codingbuddy typecheck— passyarn workspace codingbuddy test— 5822 passed