fix(plugin): guard MCP auto-registration with binary check (#1237)#1239
Merged
Conversation
Guard _ensure_mcp_json() with shutil.which('codingbuddy') so plugin-only
users without the codingbuddy binary don't get broken MCP config.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: ✅ APPROVE
CI Status: ALL PASS
Code Review
session-start.py — Minimal, effective guard:
shutil.which("codingbuddy")check before_ensure_mcp_json()— prevents broken MCP config for plugin-only users- Local import
_shutilinside try block — safe pattern
test_session_start.py — Two tests covering both paths:
test_skips_mcp_json_when_binary_not_installed: Verifies mcp.json not created when binary missingtest_creates_mcp_json_when_binary_installed: Verifies normal creation when binary exists
Issues Found: None
Recommendation: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_ensure_mcp_json()withshutil.which('codingbuddy')check so plugin-only users without the binary don't get broken MCP configCloses #1237
Test plan
python3 -m pytest hooks/test_session_start.py -v -k "mcp"— 6 passedpython3 -m pytest hooks/test_session_start.py -v— 34 passed