fix(plugin): use CLAUDE_PROJECT_DIR in user-prompt-submit hook (#1236)#1240
Merged
Conversation
Use CLAUDE_PROJECT_DIR env var instead of os.getcwd() for MCP detection and ModeEngine cwd, matching session-start.py behavior. When hook process cwd differs from the project dir, MCP detection now works correctly.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: ✅ APPROVE
CI Status: ALL PASS
Code Review
user-prompt-submit.py — Clean, minimal fix:
project_dir = os.environ.get("CLAUDE_PROJECT_DIR", os.getcwd())— matches session-start.py pattern- Both
is_mcp_available()andModeEngine()now receive resolved project_dir - No unused imports, no dead code
test_user_prompt_submit.py — Two well-structured tests:
test_claude_project_dir_env_overrides_cwd: Sets HOME/CLAUDE_PROJECT_DIR/cwd to different dirs, verifies MCP detection uses CLAUDE_PROJECT_DIRtest_claude_project_dir_with_project_mcp_json: Tests project-level .mcp.json detection via CLAUDE_PROJECT_DIR
Issues Found: None
Recommendation: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE_PROJECT_DIRenv var instead ofos.getcwd()for MCP detection andModeEnginecwd inuser-prompt-submit.pyCLAUDE_PROJECT_DIRoverride for both.claude/mcp.jsonand project-level.mcp.jsonCloses #1236
Test plan
python3 -m pytest hooks/test_user_prompt_submit.py -v— 37/37 passedyarn workspace codingbuddy test— 5822 passed