fix(rules,plugin): normalize skill ids and fix shortcut recommendations (#1243, #1247)#1249
Merged
JeremyDev87 merged 1 commit intoApr 3, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 3, 2026
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: ✅ APPROVE
CI Status: ALL PASS
Code Review
prompt_pattern_analyzer.py — All 11 _SHORTCUT_MAP entries fixed:
- Shortcuts now map to real commands:
/plan,/act,/eval(all exist incommands/) - Skill names are bare catalog names:
test-driven-development,systematic-debugging,brainstorming, etc. - No more
superpowers:oroh-my-claudecode:prefixes
solution-architect.json — 7 superpowers: references removed:
- Skill names, mandatory_checklist, verification_guide, execution_order, reference section all updated
technical-planner.json — 11 superpowers: references removed:
- Same thorough treatment across skills, mandatory_checklist, verification_guide, execution_order, execution_options, reference
Issues Found: None
Recommendation: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
superpowers:prefix from skill references insolution-architect.jsonandtechnical-planner.jsonagent definitions_SHORTCUT_MAPinprompt_pattern_analyzer.pywith real commands (/plan,/act,/eval) and bare skill names — removes allsuperpowers:*andoh-my-claudecode:*namespace referencesCloses #1243
Closes #1247
Test plan
grep -r "superpowers:" packages/rules/.ai-rules/agents/{solution-architect,technical-planner}.json— no matchesgrep -r "superpowers:\|oh-my-claudecode:" packages/claude-code-plugin/hooks/lib/prompt_pattern_analyzer.py— no matchespython3 -m pytest hooks/tests/test_prompt_pattern_analyzer.py -v— 44 passed