fix(mcp): read agent checklist and verification from activation.* path (#1253)

[JeremyDev87]

Summary

• agent-prompt.builder.ts was reading mandatory_checklist, verification_guide from top-level agent JSON paths, but the actual data lives under activation.*
• Now reads from activation.mandatory_checklist (object with {rule:...} items), activation.verification_guide, and activation.execution_order
• Keeps backward compat for top-level array format of mandatory_checklist and verification_guide

Test plan

• Test activation.mandatory_checklist (object format) → checklist rules appear
• Test activation.verification_guide → key-value guide items appear
• Test activation.execution_order (object with phase arrays) → ordered steps appear
• Test activation.execution_order (flat array) → numbered steps appear
• Test top-level array mandatory_checklist still works (backward compat)
• Test top-level verification_guide still works (backward compat)
• Test activation.mandatory_checklist takes priority over top-level array
• Test agent without activation field → graceful fallback
• All 5846 tests passing, type-check clean

Closes #1253

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
codingbuddy-landing	Ready	Preview, Comment	Apr 4, 2026 0:33am

[JeremyDev87]

Review: ✅ APPROVE

CI Status: ALL PASS

Code Review

agent-prompt.builder.ts — Activation path fix:

• Reads activation.mandatory_checklist (object with {rule:...} items) — matches actual agent JSON structure
• Falls back to top-level array format for backward compat
• activation.verification_guide rendered as key-value pairs (not raw JSON dump)
• activation.execution_order supports both object (phase→steps) and array formats
• activation.* preferred over top-level when both exist

agent-prompt.builder.spec.ts — 7 new/updated tests:

• activation.mandatory_checklist object format
• Top-level array backward compat
• Activation preferred over top-level (precedence)
• activation.verification_guide
• activation.execution_order (object and array formats)
• Graceful handling without activation field

Issues Found: None

Recommendation: APPROVE