fix(rules): backfill role.type for 18 agents (#1245)#1264
Merged
Conversation
…#1245) Add role.type to 18 agent JSON files that were invisible to type-based routing. 14 specialists get type:"specialist", 4 mode agents get type:"utility".
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 4, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: ✅ APPROVE
CI Status: ALL PASS
Code Review
18 agent JSON files updated with correct role.type:
- 14 specialists: accessibility, architecture, code-quality, code-reviewer, documentation, event-architecture, i18n, integration, observability, performance, security, seo, test-strategy, ui-ux-designer →
"type": "specialist" - 4 mode agents: plan-mode, act-mode, eval-mode, auto-mode →
"type": "utility"
Changes are minimal and consistent — one line added per file in the role object.
Issues Found: None
Recommendation: APPROVE
The schema only allowed ["primary", "specialist"], causing CI rules-validation to reject the 4 mode agents with type:"utility".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
role.type: "specialist"to 14 specialist agent JSON filesrole.type: "utility"to 4 mode agent JSON files (plan/act/eval/auto)Closes #1245
Test plan
role.typefield verified via grepyarn workspace codingbuddy test— 5849 tests passedyarn prettier --writeappliedyarn lint— no new issues