fix(mcp): filter disable-model-invocation skills from auto-recommendations (#1254)#1265
Merged
Merged
Conversation
…tions (#1254) Skills with `disable-model-invocation: true` frontmatter were still being auto-recommended. Extend skillMetadataCache to cache and filter the disableModelInvocation field alongside userInvocable.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 4, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: ✅ APPROVE
CI Status: ALL PASS
Code Review
skill-recommendation.service.ts:
skillMetadataCachetype extended to includedisableModelInvocationloadFrontmatterTriggers()caches bothuserInvocableanddisableModelInvocation- Filter at L176:
metadata?.disableModelInvocation === true→ skip (alongside existinguserInvocable === false)
skill-recommendation.service.spec.ts — 3 new tests:
disableModelInvocation: true→ excluded from recommendationsdisableModelInvocation: false→ still recommended- No field → default behavior (included)
Clean, minimal, correct.
Issues Found: None
Recommendation: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skillMetadataCacheinskill-recommendation.service.tsto cachedisableModelInvocationfield alongsideuserInvocabledisableModelInvocation: truefrom auto-recommendationstrue, included whenfalse, included when undefined (default)Closes #1254
Test plan
disableModelInvocation: trueexcluded from recommendationsdisableModelInvocation: falsestill recommendeddisableModelInvocationstill recommended (backwards compatible)