fix(mcp): add keyword triggers for 16 undiscoverable skills (#1244)#1266
Merged
Conversation
Add keyword entries (en+ko+ja+zh+es) for 16 skills missing from keywords.ts: api-design, build-fix, cost-budget, cross-repo-issues, dependency-management, finishing-a-development-branch, git-master, onboard, plan-and-review, plan-to-issues, pr-all-in-one, receiving-code-review, requesting-code-review, test-coverage-gate, using-git-worktrees, and verification-before-completion. Update tests that assumed api-design was not in SKILL_KEYWORDS and that systematic-debugging was the highest-priority trigger.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 4, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: ✅ APPROVE
CI Status: ALL PASS
Code Review
keywords.ts — 16 new skill keyword entries (1064 lines added):
| Skill | Priority | Notes |
|---|---|---|
api-design |
25 | REST/GraphQL, OpenAPI, versioning |
build-fix |
40 | Build errors, compilation failures |
cost-budget |
15 | Token cost management |
cross-repo-issues |
15 | Cross-repository tracking |
dependency-management |
25 | Dependency updates, security |
finishing-a-development-branch |
30 | Branch completion |
git-master |
40 | Git operations |
onboard |
35 | Project onboarding |
plan-and-review |
25 | Plan creation + review |
plan-to-issues |
25 | Plans → GitHub issues |
pr-all-in-one |
30 | Full PR workflow |
receiving-code-review |
25 | Handle reviews |
requesting-code-review |
25 | Request reviews |
test-coverage-gate |
30 | Coverage enforcement |
using-git-worktrees |
30 | Worktree workflow |
verification-before-completion |
35 | Pre-completion checks |
All entries include 5-language i18n (en, ko, ja, zh, es). Priority assignments are reasonable. No user-invocable: false skills included.
Issues Found: None
Recommendation: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keywords.ts: api-design, build-fix, cost-budget, cross-repo-issues, dependency-management, finishing-a-development-branch, git-master, onboard, plan-and-review, plan-to-issues, pr-all-in-one, receiving-code-review, requesting-code-review, test-coverage-gate, using-git-worktrees, and verification-before-completionapi-designwas not in SKILL_KEYWORDS and thatsystematic-debuggingwas the highest-priority triggerCloses #1244
Test plan
yarn test skill— 938 tests passyarn test— 5849 tests passnpx tsc --noEmit— no type errorsyarn lint --fix— no errorsyarn prettier --write— formatted