test(mcp): add regression coverage for core skill discovery (#1258)#1274
Merged
Conversation
Add integration assertions ensuring core skills (pr-review, systematic-debugging, database-migration, security-audit) always appear in discovery results. Also add a minimum visible skill count guard to catch mass disappearance from parser/schema regressions. Closes #1258
JeremyDev87
added
test
mcp-server
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 4, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: APPROVE ✅
CI Status: ALL PASS (25/25)
Code Quality
- Core skill regression guard correctly implemented
REQUIRED_CORE_SKILLScovers the 4 specified skills (pr-review, systematic-debugging, database-migration, security-audit)MINIMUM_VISIBLE_SKILL_COUNT = 20provides floor guard against mass disappearance- Good assertion messages explain what went wrong and likely root cause
- Uses existing
listSkillSummariesfunction — no unnecessary abstractions as constfor type safety
No Issues Found
- No unused imports/variables
- No
anytypes - Test assertions are clear and specific
- Clean insertion point in existing test file
Recommendation: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core skill regression guarddescribe block to skill-agent-discovery integration testspr-review,systematic-debugging,database-migration,security-audit) always appear in discovery resultsCloses #1258
Test plan
yarn vitest run skill-agent-discovery— 7 tests passedyarn lint— no new warningsyarn typecheck— cleanyarn vitest run— 5854 tests passed (0 failures)