fix(plugin): align standalone slash-command docs with default agents (#1261)#1275
Merged
Conversation
…1261) Replace ambiguous "Primary Developer Agent" references in commands/*.md with the actual default agent names from mode_engine.py DEFAULT_AGENTS: - plan.md → Technical Planner - act.md → Software Engineer - auto.md → Technical Planner (PLAN) / Software Engineer (ACT) Add regression test to prevent future drift between docs and engine.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 4, 2026
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: APPROVE ✅
CI Status: ALL PASS (25/25)
Code Quality
- All "Primary Developer Agent" references replaced with specific agent names
- plan.md → Technical Planner
- act.md → Software Engineer
- auto.md → per-phase agents (Technical Planner for PLAN, Software Engineer for ACT)
- Output format templates use concrete names (
## Agent : Technical Planner) - Regression test
test_standalone_docs_alignment.py(131 lines):- Parses DEFAULT_AGENTS from mode_engine.py source
- Asserts each command doc references correct agent
- Negative assertions: no "Primary Developer Agent" anywhere
- auto.md checks both PLAN and ACT agent names
No Issues Found
- No unused imports
- Clean regex-based parser for DEFAULT_AGENTS
- Comprehensive test coverage (8 test cases)
Recommendation: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commands/plan.md,commands/act.md,commands/auto.mdwith concrete agent names matchingmode_engine.pyDEFAULT_AGENTSplan.md→ Technical Planner,act.md→ Software Engineer,auto.md→ per-phase agentstest_standalone_docs_alignment.py, 9 tests) to prevent future driftCloses #1261
Test plan
yarn test:hooks— 511 passedDEFAULT_AGENTSdictyarn prettier --writeon changed .md files