improve(mcp): render agent prompts as compact execution guides (#1260)#1276
Merged
Conversation
Render mandatory_checklist as `- [name] rule` bullets, verification_guide as bullet list (array + object), execution_order with incremental numbering. Replace JSON.stringify for mode-specific instructions with readable markdown. Add trimList helper to cap long sections at 10 items + overflow indicator.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 4, 2026
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: APPROVE ✅
CI Status: ALL PASS (25/25)
Code Quality
trimList(): clean 10-item cap with "... and N more" overflowrenderValueAsText(): recursive markdown renderer replaces JSON.stringify- Mandatory checklist:
- [key] ruleformat (more informative than- [ ]) - Execution order: proper sequential numbering (was all
1.) - Mode-specific instructions: readable markdown, no JSON braces
- Backward compatibility: array format still works
Tests (6 new)
- Verification guide array rendering
- No JSON braces in mode-specific sections
- Trim mandatory checklist (15→10 + overflow)
- Trim verification guide (13→10 + overflow)
- Trim execution order (12→10 + overflow)
- Mode-specific as readable markdown
No Issues Found
- No unused imports/variables
- No
anytypes - No raw JSON in output
Recommendation: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mandatory_checklistas- [rule_name] descriptionbullets instead of checkbox formatverification_guideas bullet list, supporting both array and object formatsexecution_orderwith proper incremental numbering (1.,2.,3....)JSON.stringifyin mode-specific instructions with readable markdown viarenderValueAsTexttrimListhelper: cap long sections at 10 items +... and N moreoverflow indicator{,}) in generated prompt outputCloses #1260
Test plan