Skip to content

improve(mcp): render agent prompts as compact execution guides (#1260)#1276

Merged
JeremyDev87 merged 1 commit into
masterfrom
taskmaestro/1775265590/pane-2
Apr 4, 2026
Merged

improve(mcp): render agent prompts as compact execution guides (#1260)#1276
JeremyDev87 merged 1 commit into
masterfrom
taskmaestro/1775265590/pane-2

Conversation

@JeremyDev87

Copy link
Copy Markdown
Owner

Summary

  • Render mandatory_checklist as - [rule_name] description bullets instead of checkbox format
  • Render verification_guide as bullet list, supporting both array and object formats
  • Render execution_order with proper incremental numbering (1., 2., 3....)
  • Replace JSON.stringify in mode-specific instructions with readable markdown via renderValueAsText
  • Add trimList helper: cap long sections at 10 items + ... and N more overflow indicator
  • No raw JSON braces ({, }) in generated prompt output

Closes #1260

Test plan

  • Mandatory checklist renders with rule name prefix, not JSON objects
  • Verification guide renders as bullet list (array format)
  • Execution order renders with incremental numbered steps
  • No raw JSON braces in mode-specific instructions
  • Long sections (>10 items) trimmed with overflow indicator
  • Mode-specific instructions render as readable markdown
  • All 5858 existing tests pass
  • TypeScript type-check passes
  • Lint clean

Render mandatory_checklist as `- [name] rule` bullets, verification_guide
as bullet list (array + object), execution_order with incremental numbering.
Replace JSON.stringify for mode-specific instructions with readable markdown.
Add trimList helper to cap long sections at 10 items + overflow indicator.
@JeremyDev87 JeremyDev87 added the mcp-server apps/mcp-server label Apr 4, 2026
@vercel

vercel Bot commented Apr 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
codingbuddy-landing Ready Ready Preview, Comment Apr 4, 2026 1:32am

@JeremyDev87 JeremyDev87 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: APPROVE ✅

CI Status: ALL PASS (25/25)

Code Quality

  • trimList(): clean 10-item cap with "... and N more" overflow
  • renderValueAsText(): recursive markdown renderer replaces JSON.stringify
  • Mandatory checklist: - [key] rule format (more informative than - [ ])
  • Execution order: proper sequential numbering (was all 1.)
  • Mode-specific instructions: readable markdown, no JSON braces
  • Backward compatibility: array format still works

Tests (6 new)

  • Verification guide array rendering
  • No JSON braces in mode-specific sections
  • Trim mandatory checklist (15→10 + overflow)
  • Trim verification guide (13→10 + overflow)
  • Trim execution order (12→10 + overflow)
  • Mode-specific as readable markdown

No Issues Found

  • No unused imports/variables
  • No any types
  • No raw JSON in output

Recommendation: APPROVE

@JeremyDev87 JeremyDev87 self-assigned this Apr 4, 2026
@JeremyDev87 JeremyDev87 merged commit c7b6858 into master Apr 4, 2026
25 checks passed
@JeremyDev87 JeremyDev87 deleted the taskmaestro/1775265590/pane-2 branch April 4, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mcp-server apps/mcp-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve(mcp): render agent prompts as compact execution guides instead of raw JSON-like dumps

1 participant