feat(mcp): expose skill execution metadata in list_skills (#1259)#1277
Merged
Conversation
Extend SkillInfo with optional userInvocable, disableModelInvocation, context, agent, and allowedTools fields. Map these from the parsed skill frontmatter in listSkills. Only include fields when present to maintain backward compatibility. Closes #1259
JeremyDev87
added
feat
mcp-server
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 4, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: APPROVE ✅
CI Status: ALL PASS (25/25)
Code Quality
SkillInfoextended with 5 optional fields:userInvocable,disableModelInvocation,context,agent,allowedTools- Good JSDoc comments on each field
- Conditional inclusion (
!== undefined) preserves backward compatibility — no fields emitted when not set - Clean, minimal changes: types + service + tests
Tests (3 new)
- Metadata present: all fields correctly surfaced
- Metadata absent: all fields
undefined(backward compat) disableModelInvocationflag: correctly exposed
No Issues Found
- No unused imports/variables
- No
anytypes - No breaking changes to existing consumers
Recommendation: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SkillInfotype with optionaluserInvocable,disableModelInvocation,context,agent,allowedToolsfieldslistSkillsservice methodCloses #1259
Test plan
disableModelInvocationincluded when setyarn lint— no new warningsyarn typecheck— cleanyarn vitest run— 5863 tests passed (0 failures)