feat(council): add deterministic specialist presets for PLAN and EVAL (#1262)#1278
Merged
Conversation
…#1262) Add CouncilPresetService with deterministic council presets: - PLAN: technical-planner + architecture, test-strategy, code-quality, security - EVAL: code-reviewer + security, performance, accessibility Includes 13 unit tests covering preset resolution, determinism, and catalog validation.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 4, 2026
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: APPROVE ✅
CI Status: ALL PASS (25/25)
Code Quality
CouncilPresetService: clean NestJS injectable with deterministic presets- PLAN preset: technical-planner + architecture, test-strategy, code-quality, security
- EVAL preset: code-reviewer + security, performance, accessibility
- Returns
nullfor ACT/AUTO — no guessing - Defensive copies via spread operators prevent mutation
- Proper module registration in
AgentModule - Barrel export in
index.ts
Tests (11)
- PLAN/EVAL primary agent + specialists assertions
- Unsupported modes return null
- Determinism: same input → same output
- Catalog name format validation (kebab-case regex)
listPresets()coverage
No Issues Found
- No unused imports/variables
- No
anytypes - Clean type usage with
Extract<Mode, ...>
Recommendation: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CouncilPresetServicewith deterministic council presets for PLAN and EVAL modesAgentModuleand exported fromagent/index.tsCloses #1262
Test plan
listPresets()returns both PLAN and EVAL presets