Skip to content

feat(council): add deterministic specialist presets for PLAN and EVAL (#1262)#1278

Merged
JeremyDev87 merged 1 commit into
masterfrom
taskmaestro/1775266813/pane-2
Apr 4, 2026
Merged

feat(council): add deterministic specialist presets for PLAN and EVAL (#1262)#1278
JeremyDev87 merged 1 commit into
masterfrom
taskmaestro/1775266813/pane-2

Conversation

@JeremyDev87

Copy link
Copy Markdown
Owner

Summary

  • Add CouncilPresetService with deterministic council presets for PLAN and EVAL modes
  • PLAN preset: technical-planner (primary) + architecture, test-strategy, code-quality, security specialists
  • EVAL preset: code-reviewer (primary) + security, performance, accessibility specialists
  • Registered in AgentModule and exported from agent/index.ts

Closes #1262

Test plan

  • PLAN preset returns expected specialist set (technical-planner + 4 specialists)
  • EVAL preset returns expected specialist set (code-reviewer + 3 specialists)
  • Returns null for unsupported modes (ACT, AUTO)
  • Presets are deterministic (same input → same output)
  • All agent names match valid catalog naming format
  • listPresets() returns both PLAN and EVAL presets
  • All 13 unit tests passing
  • TypeScript strict mode — no errors
  • Lint clean (0 errors)

…#1262)

Add CouncilPresetService with deterministic council presets:
- PLAN: technical-planner + architecture, test-strategy, code-quality, security
- EVAL: code-reviewer + security, performance, accessibility

Includes 13 unit tests covering preset resolution, determinism, and catalog validation.
@JeremyDev87 JeremyDev87 added feat mcp-server apps/mcp-server labels Apr 4, 2026
@vercel

vercel Bot commented Apr 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
codingbuddy-landing Ready Ready Preview, Comment Apr 4, 2026 1:51am

@JeremyDev87 JeremyDev87 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: APPROVE ✅

CI Status: ALL PASS (25/25)

Code Quality

  • CouncilPresetService: clean NestJS injectable with deterministic presets
  • PLAN preset: technical-planner + architecture, test-strategy, code-quality, security
  • EVAL preset: code-reviewer + security, performance, accessibility
  • Returns null for ACT/AUTO — no guessing
  • Defensive copies via spread operators prevent mutation
  • Proper module registration in AgentModule
  • Barrel export in index.ts

Tests (11)

  • PLAN/EVAL primary agent + specialists assertions
  • Unsupported modes return null
  • Determinism: same input → same output
  • Catalog name format validation (kebab-case regex)
  • listPresets() coverage

No Issues Found

  • No unused imports/variables
  • No any types
  • Clean type usage with Extract<Mode, ...>

Recommendation: APPROVE

@JeremyDev87 JeremyDev87 self-assigned this Apr 4, 2026
@JeremyDev87 JeremyDev87 merged commit 76797f6 into master Apr 4, 2026
25 checks passed
@JeremyDev87 JeremyDev87 deleted the taskmaestro/1775266813/pane-2 branch April 4, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat mcp-server apps/mcp-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(council): add deterministic specialist presets for PLAN and EVAL

1 participant