test(plugin): add alignment regression coverage for Tiny Actor Grid (#1273)#1282
Merged
Conversation
…1273) Add 23 regression tests verifying display-width consistency across: - Unicode faces (◕‿◕, ⬡‿⬡, ⊙‿⊙) - ASCII fallback mode (o_o, ^_^) - CJK labels (Korean 보안/성능, Chinese 安全/性能) - Emoji faces (🤖, 👻, 🔥) - ANSI color codes (zero-width verification) - Narrow terminal widths (40/80 columns) - Mixed content grid rows Closes #1273
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 4, 2026
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: APPROVE ✅
CI Status: ALL PASS (25/25)
Code Quality
- 348-line comprehensive alignment regression suite
- Leverages existing
buddy_rendererhelpers (display_width, pad_to_display_width, render_box_line, strip_ansi, truncate_to_display_width) - 7 test sections: Unicode, ASCII, CJK, emoji, ANSI, narrow terminal, mixed grid
- Width-consistency focused — verifies uniform display width, not visual appearance
- Mock data inline — no external fixtures needed
Key Coverage
- CJK double-width: Korean (보안, 성능, 접근성) + Chinese (安全, 性能)
- ANSI zero-width: strip + width calculation verified
- Narrow terminals: 40-col and 80-col scenarios
- Mixed grid row: Unicode + CJK + emoji + ANSI in same row
No Issues Found
Recommendation: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
display_width,pad_to_display_width,render_face_banner,render_box_linefrombuddy_renderer.pyTest plan
python3 -m pytest tests/test_tiny_actor_alignment.py -v— 23 passedyarn workspace codingbuddy test— 5887 passedCloses #1273