refactor(plugin): migrate bare commands to namespaced plugin-skill delivery model (#1286)#1296
Merged
Merged
Conversation
JeremyDev87
added
refactor
plugin
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 4, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: ✅ APPROVE
CI Status: ALL PASS (26/26 checks including plugin-validate-commands)
Code Quality Assessment:
- Namespace manifest: New
buildNamespaceManifest()generatesnamespace-manifest.jsonwith full command mapping — clean build artifact - buddy.md: Quick Actions updated to
codingbuddy:*namespace - build.ts: README template updated, namespace manifest as build step 2, proper reuse of
validate-commands.tsexports - build.spec.ts: 11 new tests — namespace manifest generation (7) + packaging integration (4)
- No plugin.json changes: Lesson from Wave 8 applied correctly
- .gitignore: Build artifact
namespace-manifest.jsonproperly excluded
Architecture:
NamespaceManifestinterface cleanly exported for testing- Reuses
PLUGIN_NAMESPACE,NAMESPACE_SEPARATOR,extractCommandsFromDirectoryfrom validate-commands — DRY - Build step ordering maintained (README → namespace manifest → .mcp.json)
Checklist:
- CI ALL PASS
- No unused imports/variables
- No
anytypes - No plugin.json schema violations
- Tests cover acceptance criteria from #1286
- Lint fix applied (require → import)
✅ Review complete — solid namespace migration with build integration.
…livery model (#1286) - Update build.ts to generate namespace-manifest.json mapping bare→codingbuddy:* commands - Update README template to reference codingbuddy:* namespaced commands - Update buddy.md Quick Actions to use namespaced command references - Add namespace manifest generation tests and packaging integration tests - Add namespace-manifest.json to .gitignore (build artifact)
Fixes @typescript-eslint/no-require-imports lint error from CI.
JeremyDev87
force-pushed
the
taskmaestro/1775272188/pane-1
branch
from
76c91ba to
90d304f
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codingbuddy:*namespace delivery modelnamespace-manifest.jsonbuild artifact mapping bare command names to their namespaced equivalentscodingbuddy:plan,codingbuddy:act, etc.Changes
scripts/build.ts— NewcreateNamespaceManifest()build step +buildNamespaceManifest()exported for testing; README uses namespaced command referencesscripts/build.spec.ts— Namespace manifest generation tests + packaging integration testscommands/buddy.md— Quick Actions section updated to namespaced commands.gitignore—namespace-manifest.jsonadded (build artifact)Test plan
npx tsx scripts/validate-commands.ts— all commands pass validationyarn workspace codingbuddy exec vitest run— 5887 tests pass (236 test files)yarn workspace codingbuddy exec tsc --noEmit— clean typecheckyarn prettier --write .— formattedCloses #1286