feat(mcp): add runtime capability detection for Teams coordination (#1311)#1318
Merged
Conversation
…1311) Add TeamsCapabilityService as single source of truth for whether Teams coordination strategy is available at runtime. Capability is gated via experimental.teamsCoordination config flag or CODINGBUDDY_TEAMS_ENABLED env var, defaulting to disabled. - Add experimental schema section to CodingBuddyConfigSchema - Create TeamsCapabilityService with env > config > default resolution - Create TeamsCapabilityStatus/Source types for debugging visibility - Register in AgentModule and export from barrel - 16 unit tests covering enabled/disabled/fallback/precedence paths
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 4, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: ✅ APPROVE
CI Status: ALL PASS
Code Quality:
- TeamsCapabilityService: Clean NestJS injectable with 3-tier resolution (env > config > default)
- TeamsCapabilityStatus type:
available,source,reason— excellent debuggability - Environment override:
CODINGBUDDY_TEAMS_ENABLEDtakes precedence over config - Config-based gating:
experimental.teamsCoordinationin codingbuddy.config.json - Default: disabled — safe by default, experimental opt-in
- Tests: 172 lines, covers default/config/env/precedence/error fallback paths
- NestJS integration: Registered in AgentModule, exported via barrel
Checklist:
- CI ALL PASS
- Single source of truth for Teams capability
- Fallback: deterministic disabled state
- No modification to agent.service.ts (scope discipline)
✅ Runtime capability detection for Teams coordination established.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TeamsCapabilityServiceas single source of truth for Teams coordination availabilityexperimental.teamsCoordinationconfig flag orCODINGBUDDY_TEAMS_ENABLEDenv varChanges
config.schema.ts: Addexperimental.teamsCoordinationtoCodingBuddyConfigSchemateams-capability.types.ts:TeamsCapabilityStatusandTeamsCapabilitySourcetypesteams-capability.service.ts: Resolution order env > config > defaultteams-capability.service.spec.ts: 16 unit tests (enabled/disabled/fallback/precedence)agent.module.ts: Register and exportTeamsCapabilityServiceindex.ts: Export from barrelTest plan
yarn workspace codingbuddy exec tsc --noEmitpassesyarn workspace codingbuddy exec vitest run— 5909 tests passCloses #1311