improve(plugin): prove end-to-end /codingbuddy:* command migration#1346
Merged
Conversation
…1343) Add integration tests proving the namespace-manifest runtime path: - plugin.json name → commands/ filenames → manifest → validator consistency - Bidirectional manifest ↔ commands/ coverage - Cross-artifact namespace coherence check Clean up validator legacy terminology: - Rename LEGACY_ALLOWLIST → KNOWN_BARE_COMMANDS (deprecated alias kept) - Update comments and CLI output to reflect canonical model Align migration guide messaging: - Status column: "migration target" → "complete" - Timeline section reflects proven implementation state
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 4, 2026
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
✅ Review complete — all 25 CI checks pass
Changes:
- 9 end-to-end integration tests proving: plugin.json.name → commands/ → namespace-manifest → validator consistency
LEGACY_ALLOWLIST→KNOWN_BARE_COMMANDSrename with deprecated alias for backward compat- Migration guide status updated to "complete" with honest timeline
- Cross-artifact coherence test (plugin.json, manifest, constant all agree)
Thorough and well-structured runtime proof. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namespace-manifest.jsonis consistent with the runtime consumption path:plugin.json.name→commands/*.md→ manifest → validatorLEGACY_ALLOWLIST→KNOWN_BARE_COMMANDSto reflect the canonical namespace model (deprecated alias kept for backward compat)Closes #1343
Test plan
yarn workspace codingbuddy-claude-plugin build— succeedsyarn workspace codingbuddy-claude-plugin validate:commands— succeedsnpx vitest run— 123 tests pass (4 files)npm pack --dry-run— namespace-manifest.json present