Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/legolas-cli/tests/text_report_parity.rs
Original file line number Diff line number Diff line change
Expand Up @@ -422,11 +422,11 @@ fn scan_report_confirms_production_likely_duplicate_savings_without_other_findin
let ko_report = format_scan_report_for_language(&analysis, ReportLanguage::Ko);
let en_report = format_scan_report_for_language(&analysis, ReportLanguage::En);

assert!(ko_report.contains("확정 초기 페이로드 절감: 약 48 KB"));
assert!(!ko_report.contains("확정 초기 페이로드 절감: 미확정"));
assert!(ko_report.contains("확정 초기 페이로드 절감: 미확정"));
assert!(!ko_report.contains("확정 초기 페이로드 절감: 약 48 KB"));
assert!(ko_report.contains("초기 페이로드 절감 후보"));
assert!(en_report.contains("Confirmed initial payload savings: ~48 KB"));
assert!(!en_report.contains("Confirmed initial payload savings: not confirmed"));
assert!(en_report.contains("Confirmed initial payload savings: not confirmed"));
assert!(!en_report.contains("Confirmed initial payload savings: ~48 KB"));
assert!(en_report.contains("initial payload candidate"));
}

Expand Down
17 changes: 16 additions & 1 deletion crates/legolas-core/src/report_summary.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use crate::{
action_plan::rank_actions,
findings::FindingAnalysisSource,
models::{
Analysis, DuplicateImpactScope, ReportSummary, ReportSummaryAction,
ReportSummaryGroupSummary, ReportSummaryTextSource,
Expand Down Expand Up @@ -53,7 +54,10 @@ fn build_group_summaries(analysis: &Analysis) -> Vec<ReportSummaryGroupSummary>
let production_duplicate_kb = analysis
.duplicate_packages
.iter()
.filter(|item| item.impact_scope == DuplicateImpactScope::ProductionLikely)
.filter(|item| {
item.impact_scope == DuplicateImpactScope::ProductionLikely
&& confirms_initial_payload_savings(item.finding.analysis_source)
})
.map(|item| item.estimated_extra_kb)
.sum();
let all_duplicate_kb = analysis
Expand Down Expand Up @@ -100,6 +104,17 @@ fn build_group_summaries(analysis: &Analysis) -> Vec<ReportSummaryGroupSummary>
]
}

fn confirms_initial_payload_savings(analysis_source: Option<FindingAnalysisSource>) -> bool {
matches!(
analysis_source,
Some(
FindingAnalysisSource::SourceImport
| FindingAnalysisSource::Artifact
| FindingAnalysisSource::ArtifactSource
)
)
}

fn group_summary(
key: &str,
finding_count: usize,
Expand Down
19 changes: 14 additions & 5 deletions crates/legolas-core/tests/intelligence_impact.rs
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ fn estimate_impact_excludes_non_production_duplicate_savings_from_initial_payloa
}

#[test]
fn report_summary_separates_confirmed_initial_payload_from_directional_duplicate_opportunity() {
fn report_summary_excludes_lockfile_duplicates_from_confirmed_initial_payload() {
let mut production_duplicate =
duplicate_package_with_scope(50, DuplicateImpactScope::ProductionLikely);
production_duplicate.finding = FindingMetadata::new(
Expand Down Expand Up @@ -197,19 +197,28 @@ fn report_summary_separates_confirmed_initial_payload_from_directional_duplicate

let summary = build_report_summary(&analysis);

assert_eq!(summary.verdict_key, "targeted-impact");
assert_eq!(summary.verdict_key, "low-impact");
assert_eq!(
summary.text_source.title_key,
"report.summary.targeted-impact.title"
"report.summary.low-impact.title"
);
assert_eq!(summary.confirmed_initial_payload_kb_saved, 50);
assert_eq!(summary.confirmed_initial_payload_kb_saved, 0);
assert_eq!(summary.directional_opportunity_kb, 80);
assert_eq!(summary.estimated_lcp_improvement_ms, 105);
assert_eq!(summary.estimated_lcp_improvement_ms, 0);
assert_eq!(summary.top_actions.len(), 2);
assert_eq!(
summary.top_actions[0].finding_id,
"duplicate-package:prod-shared"
);
assert_eq!(
summary
.group_summaries
.iter()
.find(|group| group.key == "duplicate-packages")
.expect("duplicate group summary")
.confirmed_initial_payload_kb_saved,
0
);
assert_eq!(
summary
.group_summaries
Expand Down