fix(release): action smoke native runtime 설치 수정#98
Merged
Conversation
Owner
Author
|
독립 fresh-session 리뷰 결과
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
v0.1.3릴리스에서 npm publish와 published wrapper smoke는 성공했지만, 마지막 GitHub Action smoke가 checkout된 로컬 action path를 npm package로 설치하면서 native optional runtime package를 받지 못해 실패했습니다.release-docs도 tag push에서 실행되며 README 예시 태그를 현재package.json버전으로 강제하려고 해 기존 문서 계약과 충돌했습니다.변경 사항
action.yml과 marketplace wrapper action이 checkout된 로컬 경로 대신 해당 action ref의package.json버전을 읽어 publish된@jeremyfellaz/maximus@<version>을 설치하도록 변경했습니다.release-docsworkflow가masterbranch push에서만 실행되도록 제한하고,package.json단독 버전 변경으로 tag push 문서 drift 검사가 다시 실패하지 않게 했습니다.검증
node ./scripts/update-release-docs.mjs --checknode ./scripts/validate-rust-release-wiring.mjsnode --test test/release-workflow-context.test.js test/github-action-wiring.test.js test/release-docs.test.js test/release-plan.test.js test/release-candidate-metadata.test.js test/release-helpers.test.js test/npm-error-classifiers.test.js test/bump-release-version.test.jsgit diff --checkcargo metadata --format-version 1 --no-depscargo test -p maximus-corecargo test -p maximus-clinpm testnpm install --no-package-lock --no-audit --no-fund --cache /private/tmp/maximus-published-action-smoke-0.1.3/.npm-cache --prefix /private/tmp/maximus-published-action-smoke-0.1.3 @jeremyfellaz/maximus@0.1.3node ./scripts/assert-installed-native-runtime.mjs /private/tmp/maximus-published-action-smoke-0.1.3node /private/tmp/maximus-published-action-smoke-0.1.3/node_modules/@jeremyfellaz/maximus/bin/maximus.js audit ./test/fixtures/clean-project브랜치 / 워크트리
masterfeature/release-action-smoke-fix/Users/pjw/workspace/maximus