This repository was archived by the owner on Sep 23, 2020. It is now read-only.
fixed min-/max- width & height conditions#44
Open
ngehlert wants to merge 2 commits intoJeremyFagis:masterfrom
Open
fixed min-/max- width & height conditions#44ngehlert wants to merge 2 commits intoJeremyFagis:masterfrom
ngehlert wants to merge 2 commits intoJeremyFagis:masterfrom
Conversation
…and max value. fixed sass errors.
Author
|
are you still working on this project? or do you have any problems with my changes? would be great if I could get an update on this :) |
jbayona89
approved these changes
Jun 14, 2017
ph1823
reviewed
Apr 15, 2020
ph1823
left a comment
ph1823
left a comment
There was a problem hiding this comment.
And if the min and max il equal ? I have an error fro this case. Thank for your bug ^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed min-/max- width & height conditions to allow sizes same as min and max value.
e.g.
current behavior:
min-width: 420px
allowed file sizes: 421px and above
after my changes even 420 is allowed:
min-width: 420px
allowed file sizes: 420px and above
also fixed typo in readme
fixed sass errors, otherwise i could not build