fix: bump OTel packages (NU1902) and add fetch-depth for NBGV#497
Merged
JerrettDavis merged 2 commits intomainfrom Apr 26, 2026
Merged
fix: bump OTel packages (NU1902) and add fetch-depth for NBGV#497JerrettDavis merged 2 commits intomainfrom
JerrettDavis merged 2 commits intomainfrom
Conversation
v0.5.1 runs on deprecated Node.js 20 and causes intermittent 'Value cannot be null (Parameter name)' errors when writing env vars. Pin to master SHA b944774 which uses node24, until v0.5.2 is released. Affects: .github/workflows/ci.yml, .github/workflows/pr-validation.yml Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…model) - Directory.Packages.props: bump OpenTelemetry packages to address NU1902 warnings - Directory.Packages.props: align Microsoft.Extensions.* to 10.0.6 (NU1605) - .github/workflows/train-model.yml: add fetch-depth: 0 for Nerdbank.GitVersioning Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
Contributor
Code Coverage |
JerrettDavis
added a commit
that referenced
this pull request
Apr 27, 2026
…ndlers (#498) * fix: suppress CS0618 on AddZipkinExporter to unblock CI OpenTelemetry.Exporter.Zipkin 1.15.3 marks AddZipkinExporter as [Obsolete], which the compiler promotes to CS0618 error under TreatWarningsAsErrors. The project already dropped the Zipkin package version NU1902 in PR #497 but the call site pragma was never committed. Wrap the single call site with #pragma warning disable/restore CS0618 so CI compiles cleanly while backward-compat "zipkin" config support is maintained until a full OTLP migration is done. Failing file: src/JD.AI.Telemetry/Extensions/TelemetryServiceExtensions.cs Error: CS0618 @ line 101 (GitHub main) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: add --ollama-generate and --ollama-validate handlers to training Program.cs The train-model workflow fails at "Train ML.NET model" (step 9) with a FileNotFoundException on ollama_training_data.jsonl. Root cause: Program.cs had no handler for --ollama-generate or --ollama-validate. The "Synthesize training examples" step passes `--ollama-generate 150 --output src/.../intent_classifier.zip` but Program.cs silently ignored the unknown flag and fell through to the built-in seed-corpus path, writing to /tmp/intent_training_data.csv instead of the expected src/JD.AI.Workflows/Models/ollama_training_data.jsonl. When "Train ML.NET model" then ran `--data ollama_training_data.jsonl`, the file didn't exist → FileNotFoundException → exit non-zero. Fix: - Add --ollama-generate <count> handler: calls AiTrainingDataSynthesizer .GenerateAsync(count), writes results to ollama_training_data.jsonl in the same directory as --output, then exits 0. - Add --ollama-validate handler: reads --data file, calls ValidateAsync, writes disagreement count to validate_summary.txt, then exits 0. - Both handlers read OLLAMA_HOST env var (set by CI) for the Ollama URL. - Update AiTrainingDataSynthesizer constructor to accept ollamaHost param and forward it to OllamaClient. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JerrettDavis
added a commit
that referenced
this pull request
Apr 27, 2026
…ndlers (#499) * fix: suppress CS0618 on AddZipkinExporter to unblock CI OpenTelemetry.Exporter.Zipkin 1.15.3 marks AddZipkinExporter as [Obsolete], which the compiler promotes to CS0618 error under TreatWarningsAsErrors. The project already dropped the Zipkin package version NU1902 in PR #497 but the call site pragma was never committed. Wrap the single call site with #pragma warning disable/restore CS0618 so CI compiles cleanly while backward-compat "zipkin" config support is maintained until a full OTLP migration is done. Failing file: src/JD.AI.Telemetry/Extensions/TelemetryServiceExtensions.cs Error: CS0618 @ line 101 (GitHub main) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: add --ollama-generate and --ollama-validate handlers to training Program.cs The train-model workflow fails at "Train ML.NET model" (step 9) with a FileNotFoundException on ollama_training_data.jsonl. Root cause: Program.cs had no handler for --ollama-generate or --ollama-validate. The "Synthesize training examples" step passes `--ollama-generate 150 --output src/.../intent_classifier.zip` but Program.cs silently ignored the unknown flag and fell through to the built-in seed-corpus path, writing to /tmp/intent_training_data.csv instead of the expected src/JD.AI.Workflows/Models/ollama_training_data.jsonl. When "Train ML.NET model" then ran `--data ollama_training_data.jsonl`, the file didn't exist → FileNotFoundException → exit non-zero. Fix: - Add --ollama-generate <count> handler: calls AiTrainingDataSynthesizer .GenerateAsync(count), writes results to ollama_training_data.jsonl in the same directory as --output, then exits 0. - Add --ollama-validate handler: reads --data file, calls ValidateAsync, writes disagreement count to validate_summary.txt, then exits 0. - Both handlers read OLLAMA_HOST env var (set by CI) for the Ollama URL. - Update AiTrainingDataSynthesizer constructor to accept ollamaHost param and forward it to OllamaClient. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
mainis red on restore/build due toOpenTelemetry.Api 1.11.2Microsoft.Extensions.*10.0.5 -> 10.0.6 downgradesExpected impact
mainbranch CINotes
Directory.Packages.props