refactor: minor code cleanup#17
Merged
JerrettDavis merged 7 commits intomainfrom Sep 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs minor code cleanup and refactoring across the PatternKit codebase. The changes focus on improving code quality and consistency without altering core functionality.
- Refactored mediator scanning logic using a strategy pattern for better maintainability
- Simplified conditional expressions and method formatting
- Updated primary constructors for validator classes
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/PatternKit.Generators/packages.lock.json | Added package dependencies for .NET Standard 2.1, .NET 8.0, and .NET 9.0 frameworks |
| src/PatternKit.Examples/MediatorDemo/MediatorScanning.cs | New strategy-based assembly scanner for mediator components |
| src/PatternKit.Examples/MediatorDemo/Abstractions.cs | Replaced inline scanning logic with strategy-based scanner |
| src/PatternKit.Core/Structural/Composite/Composite.cs | Removed unnecessary local variable assignment |
| src/PatternKit.Core/Creational/Factory/Factory.cs | Expanded compressed conditional statements for better readability |
| src/PatternKit.Core/Creational/Builder/MutableBuilder.cs | Converted validator classes to use primary constructors |
| src/PatternKit.Core/Behavioral/Mediator/Mediator.cs | Changed return type to nullable and replaced if-else with switch expression |
| src/PatternKit.Core/Behavioral/Command/Command.cs | Simplified conditional logic using early returns and guard clauses |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 83.62% 89.73% +6.10%
==========================================
Files 37 38 +1
Lines 2333 2376 +43
Branches 356 350 -6
==========================================
+ Hits 1951 2132 +181
+ Misses 274 244 -30
+ Partials 108 0 -108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ctor/code-cleanup
Contributor
Code Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.