Skip to content

fix: merging in CI #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JesperDramsch merged 6 commits into from
Jan 19, 2026
Merged

fix: merging in CI #209

JesperDramsch merged 6 commits into from
Jan 19, 2026
+80 −3

Conversation

@JesperDramsch
Copy link
Owner

@JesperDramsch JesperDramsch commented Jan 19, 2026

  • Fix CI failures caused by interactive prompts in non-interactive environments
  • Auto-detect sub field using existing subs.yml keyword mappings (e.g., DjangoCon → WEB)
  • Fall back to DEFAULT_SUB = "PY" when no keyword match in CI mode
  • Fix load_subs() to use module-relative path (Path(file).parent) instead of hardcoded Path("utils", ...) for robustness

Test plan

  • CI merge workflow completes without EOF errors
  • DjangoCon conferences auto-detected as WEB
  • Conferences without keyword matches default to PY in CI
  • Interactive mode still prompts for missing fields locally

Fixes the error:

   What's the value of 'sub' for conference 'DjangoCon USA'...: 
   ERROR - EOF when reading a line

claude added 2 commits January 19, 2026 12:00
@claude
fix(ci): handle non-interactive mode for missing field prompts
ecf6987 
- Add auto-detection of 'sub' field based on conference name keywords
- Define default 'sub' value (PY) for conferences without keyword match
- Skip interactive prompts in CI environments (when stdin is not a tty)
- Fixes EOF error when CI tries to prompt for missing conference fields

The fill_missing_required function now:
1. Tries to auto-detect 'sub' using existing subs.yml keywords
2. Falls back to DEFAULT_SUB (PY) in non-interactive mode
3. Skips prompts for other required fields in CI (leaves as NaN for validation)
@claude
fix(subs): use module-relative path for subs.yml loading
c26582e 
- Change load_subs() to use Path(__file__).parent for robustness
- Add fallback in _load_subs_keywords() if loading fails
- Prevents failures when script is run from non-root directories
@JesperDramsch JesperDramsch merged commit 5a39ccd into main Jan 19, 2026
11 checks passed
@JesperDramsch JesperDramsch deleted the claude/fix-deprecated-project-field-34PI7 branch January 19, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JesperDramsch @claude