fix: unbound variable due to link missing #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix UnboundLocalError in sort_yaml.py by validating conferences individually instead of via list comprehension - Skip invalid conferences instead of failing the entire process - Filter out ICS calendar entries without valid links at import time
When an ICS calendar entry has no link, look up the conference name in existing YAML data and use the historical link with the year replaced. This allows conferences without descriptions to still have valid links if we've seen them before.
- Combine nested if statements in fill_links_from_history (SIM102) - Extract validate_conference helper to avoid try-except in loop (PERF203)
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.