refactor: streamline GraphQL schema by removing deprecated fields and… by mikeallisonJS · Pull Request #8915 · JesusFilm/core

mikeallisonJS · 2026-03-26T22:56:54Z

… updating input types

Removed cardBlockCreate and cardBlockUpdate mutations from api-journeys schema.
Updated adminJourney query to align with modern API structure.
Refactored DateTimeFilter input type for better clarity and usage.
Adjusted various GraphQL types to ensure consistency across schemas.
Cleaned up unused imports and types in resolver files to enhance maintainability.

Summary by CodeRabbit

New Features
- Added a nullable "notes" field to video blocks for publisher/template annotations.
Refactor
- Adjusted which APIs handle several queries and mutations, and reorganized schema annotations across media, language, and journey services.
- Removed the adminJourney query and the mutations for creating/updating card blocks and creating icon blocks (these operations are no longer exposed).
- Standardized ordering of timestamp fields across multiple types.

… updating input types - Removed `cardBlockCreate` and `cardBlockUpdate` mutations from `api-journeys` schema. - Updated `adminJourney` query to align with modern API structure. - Refactored `DateTimeFilter` input type for better clarity and usage. - Adjusted various GraphQL types to ensure consistency across schemas. - Cleaned up unused imports and types in resolver files to enhance maintainability.

coderabbitai · 2026-03-26T22:57:19Z

Walkthrough

Removed federation overrides and relocated/rescoped several block mutation fields and input/scalar declarations in the gateway schema; deleted legacy admin and create/update block mutations and their resolver/tests in api-journeys; adjusted join annotations and reordered some media fields.

Changes

Cohort / File(s)	Summary
API Gateway schema `apis/api-gateway/schema.graphql`	Consolidated/annotated `DateTime` scalar and re-scoped `DateTimeFilter`; moved/re-scoped block input types and adjusted many `@join__field`/`@join__type` annotations (affects routing of card/button/journey fields) and reordered some `Video`/`VideoBlock` fields.
API Journeys Modern schema `apis/api-journeys-modern/schema.graphql`	Removed `@override(from: "api-journeys")` directives from several Mutation/Query fields (buttonBlockCreate, buttonBlockUpdate, journeyProfileUpdate, getUserRole).
API Journeys Modern resolvers `apis/api-journeys-modern/src/schema/block/button/buttonBlockCreate.mutation.ts`, `.../buttonBlockUpdate.mutation.ts`, `.../card/cardBlockCreate.mutation.ts`, `.../journeyProfile/journeyProfileUpdate.mutation.ts`, `.../userRole/getUserRole.query.ts`	Deleted `override: { from: 'api-journeys' }` configurations or moved their placement in several field definitions; resolver logic and signatures unchanged.
API Journeys schema `apis/api-journeys/schema.graphql`, `apis/api-journeys/src/app/modules/block/card/card.graphql`, `apis/api-journeys/src/app/modules/block/icon/icon.graphql`, `apis/api-journeys/src/app/modules/journey/journey.graphql`	Removed `adminJourney` query; removed `cardBlockCreate`, `cardBlockUpdate`, and `iconBlockCreate` mutations and their input types; added nullable `notes: String` to `VideoBlock`.
API Journeys resolvers & tests `apis/api-journeys/src/app/modules/block/card/card.resolver.ts`, `.../card/card.resolver.spec.ts`, `.../icon/icon.resolver.ts`, `.../icon/icon.resolver.spec.ts`, `.../journey/journey.resolver.ts`, `.../journey/journey.resolver.spec.ts`	Deleted implementations and tests for `cardBlockUpdate`, deleted `iconBlockCreate` implementation and tests, and removed `adminJourney` resolver and its tests; corresponding auth/Prisma wiring and imports removed.
API Media schema `apis/api-media/schema.graphql`	Moved `updatedAt: DateTime!` earlier in SDL order for `BibleBook`, `Keyword`, `Video`, `VideoEdition`, and `VideoVariant` without changing types or nullability.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Possibly related PRs

chore: migrate cardblockupdate modern #8847 — modifies CardBlock update routing and @override/@join__field mapping overlapping with this change.
feat: ai translate backend #6676 — touches gateway GraphQL scalar and join annotations similar to the DateTime/join changes here.
chore: migrate buttonblockupdate #8835 — adjusts button/card mutation routing and input scoping related to buttonBlock changes.

Suggested reviewers

csiyang
edmonday

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'refactor: streamline GraphQL schema by removing deprecated fields and…' is partially related to the changeset. It captures the general refactoring intent but is incomplete (truncated with 'and…'), and the primary change involves moving card/icon block operations between API schemas rather than removing deprecated fields.	Provide a complete title that accurately describes the main change, such as 'refactor: migrate card and icon block mutations to api-journeys-modern' or similar.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch 00-00-MA-chore-modern-override-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-03-26T22:57:51Z

	Warnings
⚠️	❗ Big PR (781 changes)

(change count - 781): Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS against eb7e2d2

nx-cloud · 2026-03-26T22:58:12Z

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

_{To disable these notifications, a workspace admin can disable them in workspace settings.}

View your CI Pipeline Execution ↗ for commit eb7e2d2

Command	Status	Duration	Result
`nx run journeys-e2e:e2e`	❌ Failed	3m 21s	View ↗
`nx run journeys-admin-e2e:e2e`	✅ Succeeded	28s	View ↗
`nx run resources-e2e:e2e`	✅ Succeeded	15s	View ↗
`nx run watch-e2e:e2e`	✅ Succeeded	18s	View ↗
`nx run videos-admin-e2e:e2e`	✅ Succeeded	4s	View ↗
`nx run short-links-e2e:e2e`	✅ Succeeded	3s	View ↗
`nx run player-e2e:e2e`	✅ Succeeded	3s	View ↗
`nx run-many --target=vercel-alias --projects=jo...`	✅ Succeeded	2s	View ↗
`Additional runs (20)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-31 02:06:20 UTC

github-actions · 2026-03-26T23:00:17Z