-
Notifications
You must be signed in to change notification settings - Fork 14
fix(onboarding): ensure lastActiveTeamId is persisted before redirecting after T&C #8931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kiran-redhat
wants to merge
26
commits into
main
Choose a base branch
from
cursor/fix-e2e-failing-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
4514493
fix(e2e): fix 8 failing tests in profile, analytics, and youtube-vide…
kiran-redhat c3d9e81
fix: lint issues
autofix-ci[bot] ec93e9f
fix(e2e): use visible UI label to locate Create Custom Journey button
kiran-redhat 5fa240e
refactor(e2e): apply requirement-driven testing philosophy
kiran-redhat 4beec47
fix(e2e): remove logout toast assertion — toast never exists in app
kiran-redhat cc37e2e
fix(e2e): increase T&C page timeout to handle Vercel cold starts
kiran-redhat 5fd0811
fix(e2e): fix flaky tests and add timeout/wait-time standards
kiran-redhat 34a5e44
docs(e2e-rules): ban hard waits, require soft waits only
kiran-redhat 7d2e262
fix: lint issues
autofix-ci[bot] b0790b1
fix(e2e): pre-warm Vercel Lambdas and fix Share button timing
kiran-redhat 983012e
refactor(e2e): enforce soft wait rules and simplify global setup
kiran-redhat 1b3a8a3
refactor(e2e): enhance image handling and button interactions in card…
kiran-redhat 5b01aa2
Merge branch 'main' of https://github.com/JesusFilm/core into cursor/…
kiran-redhat d4dfbc7
fix(onboarding): ensure lastActiveTeamId is persisted before redirect…
kiran-redhat 1e5b3ae
fix(onboarding): ensure lastActiveTeamId is persisted before redirect…
kiran-redhat 5d8b7bc
fix(register): enhance account registration process and improve page …
kiran-redhat 3249931
fix: lint issues
autofix-ci[bot] 55520f0
fix(onboarding): enhance journey duplication handling and improve tes…
kiran-redhat 3805b19
Merge branch 'main' of https://github.com/JesusFilm/core into cursor/…
kiran-redhat 022fbde
Merge branch 'main' into cursor/fix-e2e-failing-tests
kiran-redhat 1fea2a4
Merge branch 'cursor/fix-e2e-failing-tests' of https://github.com/Jes…
kiran-redhat 29a36f9
fix: lint issues
autofix-ci[bot] d2b3de5
refactor: improve element selection and error handling in e2e tests
kiran-redhat bc68e60
fix: lint issues
autofix-ci[bot] 94fc5aa
fix: enhance YouTube URL validation and error handling in VideosSection
kiran-redhat 21faf63
fix: lint issues
autofix-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
# Read the specific file and lines in question wc -l apps/journeys-admin-e2e/src/pages/card-level-actions.tsRepository: JesusFilm/core
Length of output: 1867
🏁 Script executed:
Repository: JesusFilm/core
Length of output: 1056
🏁 Script executed:
Repository: JesusFilm/core
Length of output: 85
🏁 Script executed:
Repository: JesusFilm/core
Length of output: 8448
🏁 Script executed:
Repository: JesusFilm/core
Length of output: 8587
🏁 Script executed:
Repository: JesusFilm/core
Length of output: 10048
🏁 Script executed:
Repository: JesusFilm/core
Length of output: 1725
🏁 Script executed:
Repository: JesusFilm/core
Length of output: 30540
🏁 Script executed:
Repository: JesusFilm/core
Length of output: 85
Don't use
.first()to mask ambiguous drawer matchesThe locator matches two drawers when both image library and background-image properties panels are open. Disambiguate using
ImageUploadcomponent (unique to the image library drawer) instead of.first().♻️ Suggested change
📝 Committable suggestion
🤖 Prompt for AI Agents